[Refactor] Classification 2/n #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…hLightning/metrics into refactor/classification_1
for more information, see https://pre-commit.ci
…hLightning/metrics into refactor/classification_1
for more information, see https://pre-commit.ci
…hLightning/metrics into refactor/classification_1
for more information, see https://pre-commit.ci
SkafteNicki
requested review from
Borda,
justusschock,
tchaton,
ethanwharris and
SeanNaren
as code owners
justusschock
approved these changes
Jul 14, 2022
4 tasks
Borda
reviewed
Jul 15, 2022
|
|
||
| Accepts the following input tensors: | ||
|
|
||
| - ``preds`` (int or float tensor): ``(N, C, ...)``. If preds is a floating point tensor with values outside |
There was a problem hiding this comment.
Suggested change
| - ``preds`` (int or float tensor): ``(N, C, ...)``. If preds is a floating point tensor with values outside | |
| - ``preds``: ``(N, C, ...)``. If preds is a floating point tensor with values outside |
this shall come from function footprint, right so I may skip it...
in case we have it elsewhere, lets prune/simplify in another PR package-wide
There was a problem hiding this comment.
Is it clear from the function footprint? That basically just states that this is a tensor.
Maybe it is not as important for multilabel, but for multiclass it is quite important to state this since the dtype is dependent on the shape and vice versa
https://github.com/Lightning-AI/metrics/blob/4c7de2257e4f4b58be6738271d79fa67c505ea9f/src/torchmetrics/classification/jaccard.py#L106-L108
Borda
approved these changes
Jul 15, 2022
This was referenced Jul 19, 2022
This was referenced Jul 28, 2022
4 tasks
4 tasks
Borda
added a commit
that referenced
this pull request
Aug 26, 2022
* base structure * bincount * binary * files * stat score * multiclass + multilabel confmat * update * stat_score * change bincount * move back * del tests * rest of structure * confmat working * working binary stat scores * full testing * update * update * add missing tests * update * multilabel stat scores * disable old testing * more testing * flaky tests * changelog * refactor * class interface * fixes * typing * update * fix tests * Update src/torchmetrics/functional/classification/confusion_matrix.py * missing literal * add docstring to functional confusion matrix * add docstring to modular confusion matrix * add docstring to functional stat scores * add docstring to modular stat scores * make private * docs * fix mypy and doctests * fix docs formatting * literal backwards * custom movedim * docs * inits * fix * fix mistakes * working cohen kappa * Delete speed.py * cohen kappa done * working matthews * working jaccard * docstrings for jaccard * small improve * typing * fix doctest * try something * Apply suggestions from code review Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Daniel Stancl <[email protected]> Co-authored-by: Justus Schock <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
4 tasks
Borda
added a commit
that referenced
this pull request
Sep 12, 2022
* base structure * bincount * binary * files * stat score * multiclass + multilabel confmat * update * stat_score * change bincount * move back * del tests * rest of structure * confmat working * working binary stat scores * full testing * update * update * add missing tests * update * multilabel stat scores * disable old testing * more testing * flaky tests * changelog * refactor * class interface * fixes * typing * update * fix tests * Update src/torchmetrics/functional/classification/confusion_matrix.py * missing literal * add docstring to functional confusion matrix * add docstring to modular confusion matrix * add docstring to functional stat scores * add docstring to modular stat scores * make private * docs * fix mypy and doctests * fix docs formatting * literal backwards * custom movedim * docs * inits * fix * fix mistakes * working cohen kappa * Delete speed.py * cohen kappa done * working matthews * working jaccard * docstrings for jaccard * small improve * typing * fix doctest * try something * Apply suggestions from code review Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Daniel Stancl <[email protected]> Co-authored-by: Justus Schock <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
Borda
added a commit
that referenced
this pull request
Sep 12, 2022
* base structure * bincount * binary * files * stat score * multiclass + multilabel confmat * update * stat_score * change bincount * move back * del tests * rest of structure * confmat working * working binary stat scores * full testing * update * update * add missing tests * update * multilabel stat scores * disable old testing * more testing * flaky tests * changelog * refactor * class interface * fixes * typing * update * fix tests * Update src/torchmetrics/functional/classification/confusion_matrix.py * missing literal * add docstring to functional confusion matrix * add docstring to modular confusion matrix * add docstring to functional stat scores * add docstring to modular stat scores * make private * docs * fix mypy and doctests * fix docs formatting * literal backwards * custom movedim * docs * inits * fix * fix mistakes * working cohen kappa * Delete speed.py * cohen kappa done * working matthews * working jaccard * docstrings for jaccard * small improve * typing * fix doctest * try something * Apply suggestions from code review Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Daniel Stancl <[email protected]> Co-authored-by: Justus Schock <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
Borda
added a commit
that referenced
this pull request
Sep 13, 2022
* base structure * bincount * binary * files * stat score * multiclass + multilabel confmat * update * stat_score * change bincount * move back * del tests * rest of structure * confmat working * working binary stat scores * full testing * update * update * add missing tests * update * multilabel stat scores * disable old testing * more testing * flaky tests * changelog * refactor * class interface * fixes * typing * update * fix tests * Update src/torchmetrics/functional/classification/confusion_matrix.py * missing literal * add docstring to functional confusion matrix * add docstring to modular confusion matrix * add docstring to functional stat scores * add docstring to modular stat scores * make private * docs * fix mypy and doctests * fix docs formatting * literal backwards * custom movedim * docs * inits * fix * fix mistakes * working cohen kappa * Delete speed.py * cohen kappa done * working matthews * working jaccard * docstrings for jaccard * small improve * typing * fix doctest * try something * Apply suggestions from code review Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Daniel Stancl <[email protected]> Co-authored-by: Justus Schock <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
Borda
added a commit
that referenced
this pull request
Sep 13, 2022
* base structure * bincount * binary * files * stat score * multiclass + multilabel confmat * update * stat_score * change bincount * move back * del tests * rest of structure * confmat working * working binary stat scores * full testing * update * update * add missing tests * update * multilabel stat scores * disable old testing * more testing * flaky tests * changelog * refactor * class interface * fixes * typing * update * fix tests * Update src/torchmetrics/functional/classification/confusion_matrix.py * missing literal * add docstring to functional confusion matrix * add docstring to modular confusion matrix * add docstring to functional stat scores * add docstring to modular stat scores * make private * docs * fix mypy and doctests * fix docs formatting * literal backwards * custom movedim * docs * inits * fix * fix mistakes * working cohen kappa * Delete speed.py * cohen kappa done * working matthews * working jaccard * docstrings for jaccard * small improve * typing * fix doctest * try something * Apply suggestions from code review Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Daniel Stancl <[email protected]> Co-authored-by: Justus Schock <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Continues work on classification refactor #1001
Prior work: #1054
This PR takes care of
CohenKappa,JaccardIndexandMatthewsCorrCoefwhich all are subclassed fromConfusionMatrix.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃